Update InsertionDeviceEnergy attributes to public#1966
Open
oliwenmandiamond wants to merge 5 commits intomainfrom
Open
Update InsertionDeviceEnergy attributes to public#1966oliwenmandiamond wants to merge 5 commits intomainfrom
oliwenmandiamond wants to merge 5 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1966 +/- ##
=======================================
Coverage 99.11% 99.11%
=======================================
Files 318 318
Lines 12354 12354
=======================================
Hits 12245 12245
Misses 109 109 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Relm-Arrowny
approved these changes
Mar 27, 2026
Contributor
Relm-Arrowny
left a comment
Relm-Arrowny
left a comment
There was a problem hiding this comment.
Thanks for doing it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In reference to https://github.com/DiamondLightSource/sm-bluesky/pull/100/changes, a plan is trying to access private members. Update these to public.
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}